fix(ci): pin docker/login-action to full SHA for SonarCloud - #91
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(ci): pin docker/login-action to full SHA for SonarCloud#91cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
SonarCloud quality gate on main fails with C security rating on new code because docker/login-action@v4 uses a floating tag (githubactions:S7637). Pin both GHCR and Quay login steps to the v4 release commit. Co-authored-by: Alexander Wagner <info@alexanderwagnerdev.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SonarCloud's quality gate on
mainfails with a C security rating on new code becausedocker/login-action@v4uses a floating tag (rulegithubactions:S7637).Changes
docker/login-actionsteps in.github/workflows/docker-multiarch.ymlto the v4 release commitaf1e73f918a031802d376d3c8bbc3fe56130a9b0.Broken by
PR #71 introduced Quay.io login with floating
docker/login-action@v4tags.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.